Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): update rector/rector requirement from 0.13.0 to 0.13.2 #6052

Merged
merged 8 commits into from
May 31, 2022
Merged

chore(deps-dev): update rector/rector requirement from 0.13.0 to 0.13.2 #6052

merged 8 commits into from
May 31, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 30, 2022

Updates the requirements on rector/rector to permit the latest version.

Release notes

Sourced from rector/rector's releases.

Released Rector 0.13.2

Bugfixes 🐛

  • Fix missing ReflectionUnionType class by moving stub loader to RectorContainerFactory (#2382)
Commits
  • 5c55299 Rector 0.13.2
  • 64b3510 Updated Rector to commit 31e60de5c9fc7ce2f71c6af2c9a22b634b77809f
  • 15bac77 Updated Rector to commit e89590f92503dc848855035f76da5aa607370fe4
  • 85ff702 Updated Rector to commit 38cb4c9684920ceeb121ced398fd7e3c70f6435e
  • efe571a Rector 0.13.1
  • ed2a4f1 Updated Rector to commit 429e5746ea00b435d7a785c7716600e556b4d3d2
  • 5ac1afd Updated Rector to commit 7f40d20ff75b7a712815862110c66c445e1fb8c5
  • b748edb Updated Rector to commit 37df55a2fd1a2d6baceb128d8d25cabb19bea833
  • 72da510 Updated Rector to commit 30b5b53c0ed3031b75341efe02a53d8367861dd4
  • 4838a73 Updated Rector to commit 38ed8d2f6d765cc8ca7bfa9d2c3105d05f9109ff
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
chore(deps-dev): update rector/rector requirement from 0.13.0 to 0.13.2
511286b 
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@0.13.0...0.13.2)

---
updated-dependencies:
- dependency-name: rector/rector
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update external dependencies php Pull requests that update Php code labels May 30, 2022
@samsonasik samsonasik self-assigned this May 30, 2022
@samsonasik
Copy link
Member

I cleaned up config, re-run rector, and set alias to Config\ClassName when lastname is exists in use statements

@samsonasik
Copy link
Member

test error on Oracle test seems unrelated:

1) CodeIgniter\Commands\CreateDatabaseTest::testCreateDatabase
Error: Undefined constant "CodeIgniter\Database\OCI8\OCI_COMMIT_ON_SUCCESS"

@samsonasik
Copy link
Member

PHPStan internal error seems unrelated:

Error: Internal error: Internal error: Undefined constant "CodeIgniter\Database\OCI8\OCI_COMMIT_ON_SUCCESS" in file /home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/OCI8/Builder.php
Run PHPStan with -v option and post the stack trace to:
https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md
Error: Child process error (exit code 1): 
 -- --------------------------------------------------------------------------- 
     Error                                                                      
 -- --------------------------------------------------------------------------- 
     Internal error: Internal error: Undefined constant                         
     "CodeIgniter\Database\OCI8\OCI_COMMIT_ON_SUCCESS" in file                  
     /home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/OCI8/Builder.

It seems we need to create a fallback check on when OCI_COMMIT_ON_SUCCESS constant not exists.

@samsonasik
Copy link
Member

@kenjis I've added phpstan-bootstrap.php to include the fallback OCI_COMMIT_ON_SUCCESS constant when not defined 503ee82

@kenjis
Copy link
Member

kenjis commented May 30, 2022

@samsonasik Sorry, CodeIgniter\Services is not what I thought. I was confused it with CodeIgniter\Confg\Services.
I need to investigate it.

https://github.com/codeigniter4/CodeIgniter4/blob/develop/tests/_support/Services.php

@samsonasik
Copy link
Member

@kenjis ok, just let me know if I need to update it.

@kenjis kenjis mentioned this pull request May 31, 2022
Merged
5 tasks
@kenjis
Copy link
Member

kenjis commented May 31, 2022

Probably CodeIgniter\Services is not needed. See #6053
So this PR is okay.

@samsonasik
Copy link
Member

samsonasik commented May 31, 2022 •
edited
Loading

Ok, I set set reportUnmatchedIgnoredErrors: false and rollback ignore error formatter not nullable on CodeIgniter\Debug\Exceptions and CodeIgniter\Test\Mock\MockResourcePresenter as in Github action it show error when not ignored bb6f3a2, while in local is working ok.

@kenjis
Copy link
Member

kenjis commented May 31, 2022

Why reportUnmatchedIgnoredErrors: false?
I think it is better to set true.

@samsonasik
Copy link
Member

It got warning in my local, while working on CI, ok, I set back to true

kenjis
kenjis reviewed May 31, 2022
View reviewed changes
phpstan-bootstrap.php Outdated Show resolved Hide resolved
@samsonasik @kenjis
Update phpstan-bootstrap.php
724828d 
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik
Copy link
Member

All green 🎉 , let's merge it, thank you @kenjis @paulbalandan for the review.

@samsonasik samsonasik merged commit 0c66d6b into develop May 31, 2022
@samsonasik samsonasik deleted the dependabot/composer/rector/rector-0.13.2 branch May 31, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan left review comments

@samsonasik samsonasik samsonasik left review comments

@kenjis kenjis kenjis left review comments

Assignees

@samsonasik samsonasik

Labels
dependencies Pull requests that update external dependencies php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @kenjis @paulbalandan